-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for IE #9
base: main
Are you sure you want to change the base?
Conversation
This is discussed in unifiedjs/unified#55 . I'm not quite sure if a "guide" is too much for this question. Perhaps a FAQ is a better place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time for making this!
As of now I'd say this guide is a bit too specific as it's just for IE. We found out browser support is a common question and, as mentioned in #7 (comment), we'd like to tackle that in a guide that encapsulates browser support in general. Moreover, the current state of the guide would need some grooming to align with the previous guides. The latter can take quite some iterations and possibly become a bit nit-picky so I have a proposal for you. If you change the following points I am willing to pick it up from there and make it comply with the previous guides.
Requested changes:
- Switch from “Use unified in Internet Explorer” to “Setting up tooling for browser support”
- Add sections for (some) of the following on how to compile unified with:
- Rollup
- WebPack
- Angular CLI
- Create React App
- Vue CLI
- Switch from bash commands (such as
cat > src/index.js <<EOF...
) to code snippets. - Switch from screenshots of the console to 'printing' the output as text in the guide.
Let me know if you need help or some pointers.
@jasonqsong I think what @Murderlon makes a lot of sense for our use cases, but would like to express that I’m extremely grateful that you started work on this! 💪 |
The proposal looks good to me :) I'm not very familiar with angular or vue. I can only help the webpack part and the react part. Besides, I think the import, async/await of ES2016+ may need to be mentioned somewhere. And TypeScript needs to turn on "esModuleInterop". But for most React/Angular user, |
No description provided.