Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtualenv to Vagrantfile in order to remove sudo #2

Merged
merged 1 commit into from
Jul 5, 2016

Conversation

cristobal23
Copy link
Contributor

Greetings folks!
I offer my suggestions here in this pull request.

  • Adding the config.ssh.shell option allows vagrant to start bash as a non-login shell which prevents a stdin: is not a tty error from coming up.
  • Removing the commented out sudo apt-get update as the vagrant provisioner only runs when the virtual machine is created unless the option --provision is passed the next time you run vagrant.
  • Adding a virtualenv prevents the potential of corrupting system libraries. This layer of separation can be useful even in a sandboxed operating system whether in a virtual machine or a container.
  • Speaking of containers, you can achieve a similar sandbox with this command:
docker run -i --rm -v $(pwd):/opt -w='/opt' python:2 /bin/bash -c "virtualenv venv && source venv/bin/activate && pip install -e ."

Please let me know what you think about these suggestions.

@yuhunglin
Copy link
Contributor

@cristobal23 This looks good, thanks for the suggestions, feel free to chime in on other elements as well.

@yuhunglin yuhunglin merged commit f082ebe into unifio:master Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants