-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add arc compute and juice labs serving tool #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ZoeCD, sorry for the late review! Just left a few commments on the images would be cool if you could address those, gracias!
serving/arc-compute.yaml
Outdated
arc-compute: | ||
name: "Arc Compute" | ||
|
||
image_url: https://avatars.githubusercontent.com/u/91487685?s=200&v=4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the value to just be arccompute.png
? We upload the images separately to avoid issues with image hosts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. But where do I upload the images? Here?
serving/juice-labs.yaml
Outdated
juice-labs: | ||
name: "Juice Labs" | ||
|
||
image_url: https://avatars.githubusercontent.com/u/72895430?s=200&v=4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, just juicelabs.png
would do the trick
Closes #49
Closes #51