Config.uk: Fix paging configuration typo
#18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration name is `PAGING`, not `CONFIG_PAGING`. I have fixed this typo. Signed-off-by: Costin Sin <sin.costinrobert@gmail.com>
costinsin
changed the title
Config.uk: Fix configuration typoConfig.uk: Fix paging configuration typo
razvand
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
This works. Thanks, @costinsin. @skuenzer , please approve it when you have the time.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
StefanJum
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Aug 16, 2023
The configuration name is `PAGING`, not `CONFIG_PAGING`. I have fixed this typo. Signed-off-by: Costin Sin <sin.costinrobert@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration name is
PAGING, notCONFIG_PAGING.I have fixed this typo.