This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Add configuration and scripts #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduNichita
suggested changes
Aug 6, 2023
There was a problem hiding this comment.
All good with me besides that one small comment. Thanks @razvand
| For building and running everything for `x86_64`, follow the steps below: | ||
|
|
||
| ```console | ||
| git clone https://github.com/unikraft/app-helloworld-cpp helloworld-cpp |
There was a problem hiding this comment.
I think we need to separate the common commands (the ones with cloning the repos) from the one specific to platform / architectures.
There was a problem hiding this comment.
I see your point. But, currently, this is how we did for all repositories. I would keep it like this, and, if we think it's a good idea, we will update it all over the place.
There was a problem hiding this comment.
Ok, fair point. Then let's merge like it is.
RaduNichita
approved these changes
Aug 6, 2023
StefanJum
suggested changes
Aug 6, 2023
|
@StefanJum, fixed. |
razvand
force-pushed
the
razvand/add-config-and-scripts
branch
from
f5431fa
to
17d935c
Compare
Ignore output files and directories. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Add configuration files for Make-based platform / architecture combinations. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Add basic Makefile for Make-based setup. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Explicitly enable depending libraries. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Add information on using KraftKit and on using the Make-based build system. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
razvand
force-pushed
the
razvand/add-config-and-scripts
branch
from
17d935c
to
b48dd6a
Compare
StefanJum
approved these changes
Aug 10, 2023
RaduNichita
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
All good with rebase. Thanks, @razvand!
Reviewed-by: Radu Nichita radunichita99@gmail.com
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Add configuration files for Make-based platform / architecture combinations. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #16
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Add basic Makefile for Make-based setup. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #16
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Explicitly enable depending libraries. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #16
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Add information on using KraftKit and on using the Make-based build system. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Make-based setup files.