Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Update platform to qemu for all targets #13

Closed
wants to merge 1 commit into from

Conversation

gabrielmocanu
Copy link
Member

Update targets to qemu and modify the order for all libraries.

Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io

Update targets to qemu and modify the order for all libraries.

Signed-off-by: Gabriel Mocanu <gabi.mocanu98@gmail.com>
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline KraftKit has been updated to handle the fc/firecracker alias variants

kraft.yaml Show resolved Hide resolved
@razvand
Copy link
Contributor

razvand commented Jul 25, 2023

@nderjung , what needs to happen here? Use fc instead of firecracker?

@gabrielmocanu
Copy link
Member Author

@nderjung , what needs to happen here? Use fc instead of firecracker?

Both are accepted, you can see this here.

@razvand razvand requested a review from nderjung August 6, 2023 07:41
@razvand razvand added the enhancement New feature or request label Aug 6, 2023
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci/merged enhancement New feature or request
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

5 participants