-
Notifications
You must be signed in to change notification settings - Fork 8
kraft.yaml: Update configuration to use Musl #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, however, I believe that also changing the unikraft version and adding ARM
as an architecture would make sense.
Thanks, @mariasfiraiala . Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, thanks @razvand !
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
Add `arm64` architecture and `kvm` platform as target. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Replace `newlibc` and `pthread-embedded` libraries with `musl`. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks
Approved-by: Alexander Jung alex@unikraft.io
Replace `newlibc` and `pthread-embedded` libraries with `musl`. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Alexander Jung <alex@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #5
Update configuration to use Musl, instead of newlib and pthread-embedded