This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
kraft.yaml: Update configuration to use Musl #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, @mariasfiraiala . Fixed. |
mariasfiraiala
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Works, thanks @razvand !
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
Add `arm64` architecture and `kvm` platform as target. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Replace `newlibc` and `pthread-embedded` libraries with `musl`. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
nderjung
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Looks good! Thanks
Approved-by: Alexander Jung alex@unikraft.io
unikraft-bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
Replace `newlibc` and `pthread-embedded` libraries with `musl`. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Alexander Jung <alex@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update configuration to use Musl, instead of newlib and pthread-embedded