fix(lint): address unused code

GitHub-Fixes: #413 Signed-off-by: Antoine Cotten <antoine@unikraft.io>
unikraft · Apr 28, 2023 · 020202f · 020202f
1 parent 8d4f1a1
commit 020202f
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 176 deletions.
diff --git a/.github/workflows/gochecks.yaml b/.github/workflows/gochecks.yaml
@@ -42,6 +42,9 @@ jobs:
           sudo apt-get install -y --no-install-recommends \
             cmake
 
+      - name: Install libgit2/git2go
+        run: make git2go
+
       - name: Check that go.mod is tidy
         uses: protocol/multiple-go-modules@v1.2
         with:

diff --git a/.golangci.yaml b/.golangci.yaml
@@ -8,6 +8,8 @@ run:
     # Temporarily ignore the file which uses libgit2 dependency since this will 
     # fail on the static check.
     - manifest/pack_pull_git.go
+  build-tags:
+    - static
 
 linters:
   disable-all: true

diff --git a/go.mod b/go.mod
@@ -55,7 +55,6 @@ require (
 	github.com/xlab/treeprint v1.2.0
 	golang.org/x/oauth2 v0.6.0
 	golang.org/x/sync v0.1.0
-	golang.org/x/sys v0.7.0
 	golang.org/x/term v0.7.0
 	gopkg.in/yaml.v2 v2.4.0
 	gopkg.in/yaml.v3 v3.0.1
@@ -162,6 +161,7 @@ require (
 	golang.org/x/crypto v0.6.0 // indirect
 	golang.org/x/mod v0.9.0 // indirect
 	golang.org/x/net v0.8.0 // indirect
+	golang.org/x/sys v0.7.0 // indirect
 	golang.org/x/text v0.8.0 // indirect
 	golang.org/x/tools v0.7.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect

diff --git a/iostreams/console.go b/iostreams/console.go
diff --git a/iostreams/console_windows.go b/iostreams/console_windows.go
diff --git a/iostreams/tty_size.go b/iostreams/tty_size.go
diff --git a/iostreams/tty_size_windows.go b/iostreams/tty_size_windows.go
diff --git a/unikraft/lib/library.go b/unikraft/lib/library.go
@@ -79,25 +79,31 @@ type LibraryConfig struct {
 	// ultimately handled by the packmanager).
 	source string
 
+	// TODO(nderjung): future implementation
 	// origin contains the URL of the remote source code if this library wraps an
 	// existing library.
-	origin string
+	//nolint:gofumpt
+	//origin string
 
 	// list of kconfig values specific to this library.
 	kconfig kconfig.KeyValueMap
 
 	// kname the kconfig name which enables this library.
 	kname string
 
+	// TODO(nderjung): future implementation
 	// projectdir is the root location of the project that this library is a
 	// member of.
-	projectdir string
+	//nolint:gofumpt
+	//projectdir string
 
 	// path is the location to this library within the context of a project.
 	path string
 
+	// TODO(nderjung): future implementation
 	// patchdir is the directory where patches to the origin library are kept.
-	patchdir string
+	//nolint:gofumpt
+	//patchdir string
 
 	// exportsyms contains the list of exported symbols the library makes
 	// available via the standard `exportsyms.uk` file.