feat(paraprogress): Introduce WithTimeout option (#961)

Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io> Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
unikraft · Nov 1, 2023 · 3a23f90 · 3a23f90
2 parents edb2ffd + 91c6401
commit 3a23f90
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/tui/paraprogress/options.go b/tui/paraprogress/options.go
@@ -4,6 +4,8 @@
 // You may not use this file except in compliance with the License.
 package paraprogress
 
+import "time"
+
 type ParaProgressOption func(md *ParaProgress) error
 
 func WithRenderer(norender bool) ParaProgressOption {
@@ -33,3 +35,10 @@ func WithNameWidth(width int) ParaProgressOption {
 		return nil
 	}
 }
+
+func WithTimeout(timeout time.Duration) ParaProgressOption {
+	return func(pp *ParaProgress) error {
+		pp.timeout = timeout
+		return nil
+	}
+}
diff --git a/tui/paraprogress/paraprogress.go b/tui/paraprogress/paraprogress.go
@@ -8,6 +8,7 @@ import (
 	"context"
 	"fmt"
 	"os"
+	"time"
 
 	"github.com/barkimedes/go-deepcopy"
 	tea "github.com/charmbracelet/bubbletea"
@@ -34,6 +35,7 @@ type ParaProgress struct {
 	errChan       chan error
 	failFast      bool
 	nameWidth     int
+	timeout       time.Duration
 }
 
 func NewParaProgress(ctx context.Context, processes []*Process, opts ...ParaProgressOption) (*ParaProgress, error) {
@@ -71,6 +73,7 @@ func NewParaProgress(ctx context.Context, processes []*Process, opts ...ParaProg
 	for i := range processes {
 		processes[i].norender = md.norender
 		processes[i].NameWidth = maxNameLen
+		processes[i].timeout = md.timeout
 
 		pctx, err := deepcopy.Anything(ctx)
 		if err != nil {

diff --git a/tui/paraprogress/process.go b/tui/paraprogress/process.go
@@ -6,6 +6,7 @@ package paraprogress
 
 import (
 	"context"
+	"fmt"
 	"strings"
 	"sync"
 	"time"
@@ -78,6 +79,7 @@ type Process struct {
 	err         error
 	norender    bool
 	ctx         context.Context
+	timeout     time.Duration
 
 	Name      string
 	NameWidth int
@@ -213,6 +215,11 @@ func (d *Process) Update(msg tea.Msg) (*Process, tea.Cmd) {
 
 	// TickMsg is sent when the spinner wants to animate itself
 	case spinner.TickMsg:
+		if d.timeout != 0 && d.timer.Elapsed() > d.timeout {
+			d.err = fmt.Errorf("process timedout after %s", d.timeout.String())
+			d.Status = StatusFailed
+		}
+
 		d.spinner, cmd = d.spinner.Update(msg)
 		cmds = append(cmds, cmd)
 
@@ -291,7 +298,7 @@ func (p Process) View() string {
 		truncate := 0
 		loglen := len(p.logs) - LOGLEN
 
-		if loglen > 0 {
+		if p.Status != StatusFailed {
 			truncate = loglen
 		}