feat(list): Wrap the Catalog lookup with a processtree (#937)

Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io> Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
unikraft · Oct 26, 2023 · 72463b0 · 72463b0
2 parents 386f257 + 6c4d26f
commit 72463b0
Showing 1 changed file with 38 additions and 3 deletions.
diff --git a/internal/cli/kraft/pkg/list/list.go b/internal/cli/kraft/pkg/list/list.go
@@ -14,6 +14,8 @@ import (
 	"github.com/MakeNowJust/heredoc"
 	"github.com/spf13/cobra"
 
+	"kraftkit.sh/config"
+	"kraftkit.sh/tui/processtree"
 	"kraftkit.sh/unikraft/app"
 
 	"kraftkit.sh/cmdfactory"
@@ -121,14 +123,42 @@ func (opts *ListOptions) Run(ctx context.Context, args []string) error {
 
 		fmt.Fprint(iostreams.G(ctx).Out, project.PrintInfo(ctx))
 	} else {
-		found, err := packmanager.G(ctx).Catalog(ctx,
-			packmanager.WithUpdate(opts.Update),
-			packmanager.WithTypes(types...),
+		var found []pack.Package
+
+		parallel := !config.G[config.KraftKit](ctx).NoParallel
+		norender := log.LoggerTypeFromString(config.G[config.KraftKit](ctx).Log.Type) != log.FANCY
+
+		treemodel, err := processtree.NewProcessTree(
+			ctx,
+			[]processtree.ProcessTreeOption{
+				processtree.IsParallel(parallel),
+				processtree.WithRenderer(norender),
+				processtree.WithFailFast(true),
+				processtree.WithHideOnSuccess(true),
+			},
+			processtree.NewProcessTreeItem(
+				"updating index...", "",
+				func(ctx context.Context) error {
+					found, err = packmanager.G(ctx).Catalog(ctx,
+						packmanager.WithUpdate(opts.Update),
+						packmanager.WithTypes(types...),
+					)
+					if err != nil {
+						return err
+					}
+
+					return nil
+				},
+			),
 		)
 		if err != nil {
 			return err
 		}
 
+		if err := treemodel.Start(); err != nil {
+			return fmt.Errorf("could not complete search: %v", err)
+		}
+
 		for _, p := range found {
 			format := p.Format().String()
 			if _, ok := packages[format]; !ok {
@@ -139,6 +169,11 @@ func (opts *ListOptions) Run(ctx context.Context, args []string) error {
 		}
 	}
 
+	if len(packages) == 0 {
+		log.G(ctx).Info("no packages found")
+		return nil
+	}
+
 	for format, packs := range packages {
 		// Sort packages by type, name, version, format
 		sort.Slice(packs, func(i, j int) bool {