Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create): Add environment variables #1536

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

LucaSeri
Copy link
Contributor

@LucaSeri LucaSeri commented Apr 10, 2024

This is trivial as the compose-go parser takes in the environemnt and .env_file fields from the compose file and parses them. They are then taken care of by the underlying implementation in Run.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

This is trivial as the compose-go parser takes in the environemnt
and .env_file fields from the compose file and parses them. They
are then taken care of by the underlying implementation in Run.

Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
@LucaSeri LucaSeri requested a review from nderjung April 10, 2024 12:55
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@nderjung nderjung merged commit 54c5745 into unikraft:staging Apr 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants