refactor(webinstall): Reprompt after invalid input instead of exiting #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
changed the title
craciunoiuc
changed the title
craciunoiuc
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Hey @HendrikHuebner
Looks really good, left you a comment. I still need to try it out.
Can you also reword your commit to start with refactor(webinstall): 🙏
refactor(webinstall): Prompt user again on invalid input instead of exiting
Make sure you leave a single commit afterwards
craciunoiuc
changed the title
craciunoiuc
requested changes
Apr 23, 2024
HendrikHuebner
force-pushed
the
staging
branch
2 times, most recently
from
312fe0b
to
41eac00
Compare
Signed-off-by: Hendrik Hübner <117831077+HendrikHuebner@users.noreply.github.com>
craciunoiuc
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Closes #1561
When a user enters something invalid in response to a prompt by the webinstall script, the script now displays a message such as:
Invalid input. Please try again or exit with Ctrl+C.Additionally, for yes/no questions I have created the prompt_user_yes_no function, which simplifies the script a little bit since it gets rid of some duplicated code.