fix(kraft): Only accept single target in utils.BuildRootfs
#1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a number of issues simultaneously by removing the ability to build multiple targets at once in the utility method `BuildRootfs`; 1. The resulting rootfs string would be overwritten by the last build rootfs, resulting in potential mismatch between the resulting architecture of the rootfs; 2. Returning the discovered command-line and environmental variables as a single slice, preventing duplication; 3. Appending environmental variables to user-supplied ones made with the `-e` flag. Signed-off-by: Alexander Jung <alex@unikraft.io>
craciunoiuc
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This commit fixes a number of issues simultaneously by removing the ability to build multiple targets at once in the utility method
BuildRootfs;-eflag.