fix(run): Prevent possible nil-pointers by always using Cut
#1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing environmental variables in `kraft run`, which are often presented in circumstances with strings with an equals delimeter, the use of `SplitN` was not always checked for empty values. To prevent possible nil-pointers and to keep code consistent, replace all areas where this type of procedure occurs with `strings.Cut` instead. Signed-off-by: Alexander Jung <alex@unikraft.io>
craciunoiuc
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
When parsing environmental variables in
kraft run, which are often presented in circumstances with strings with an equals delimeter, the use ofSplitNwas not always checked for empty values. To prevent possible nil-pointers and to keep code consistent, replace all areas where this type of procedure occurs withstrings.Cutinstead.