Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): Initialize env map if nil #1613

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

LucaSeri
Copy link
Contributor

@LucaSeri LucaSeri commented Apr 28, 2024

PR 1575 introduced env variables from docker, but there was no guarantee that the machine env map was ever initialized at this point.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Github-Fixes: #1612

PR 1575 introduced env variables from docker, but there
was no guarantee that the machine env map was ever initialized
at this point.

Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
@LucaSeri LucaSeri requested a review from nderjung April 28, 2024 11:15
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nderjung nderjung merged commit c04feb2 into unikraft:staging Apr 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the App Catalog - HTTP Go Server
2 participants