Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale): Correctly check for minimum warm/cool period #1617

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/cli/kraft/cloud/scale/initialize/initialize.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@ func (opts *InitOptions) Run(ctx context.Context, args []string) error {
id = conf.UUID
}

if opts.WarmupTime < time.Millisecond {
return fmt.Errorf("warmup time must be at least 1ms")
if opts.WarmupTime < 10*time.Millisecond {
return fmt.Errorf("warmup time must be at least 10ms")
}

if opts.CooldownTime < time.Millisecond {
return fmt.Errorf("cooldown time must be at least 1ms")
if opts.CooldownTime < 10*time.Millisecond {
return fmt.Errorf("cooldown time must be at least 10ms")
}

var master kcautoscale.CreateRequestMaster
Expand Down
Loading