fix(build): Handle presence of non-existent Dockerfile
#1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect whether the supplied Dockerfile exists before passing it to the packaging step. If a non-empty value for the Rootfs attribute is supplied to the packaging step, it will trickle through the rootfs build system and may cause failure due to misconfiguration. This is because the value of `service.Build.Dockerfile` is by default set to "Dockerfile" which may in fact not exist. The packaging step relies on the present of a Kraftfile which supersedes the Dockerfile. Signed-off-by: Alexander Jung <alex@unikraft.io>
nderjung
force-pushed
the
nderjung/fix/internal/cli/kraft/cloud/compose/build/fix-kraftfile-supercedes-dockerfile
branch
from
881f016
to
e94c528
Compare
craciunoiuc
changed the title
DockerfileDockerfile
craciunoiuc
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Detect whether the supplied Dockerfile exists before passing it to the packaging step. If a non-empty value for the Rootfs attribute is supplied to the packaging step, it will trickle through the rootfs build system and may cause failure due to misconfiguration. This is because the value of
service.Build.Dockerfileis by default set to "Dockerfile" which may in fact not exist. The packaging step relies on the present of a Kraftfile which supersedes the Dockerfile.