feat(e2e): Add 'pkg source/unsource' tests #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
added
kind/enhancement
craciunoiuc
force-pushed
the
craciunoiuc/test-e2e-source-unsource
branch
3 times, most recently
from
4c41358
to
8289757
Compare
antoineco
reviewed
Sep 15, 2023
antoineco
reviewed
Sep 15, 2023
antoineco
reviewed
Sep 15, 2023
antoineco
reviewed
Sep 15, 2023
craciunoiuc
force-pushed
the
craciunoiuc/test-e2e-source-unsource
branch
from
8289757
to
cbb73ad
Compare
antoineco
reviewed
Sep 15, 2023
| // https://www.regular-expressions.info/nonprint.html | ||
| // https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797 | ||
| Expect(stdout.String()).To(MatchRegexp(`\x1b\[2K\[\+\] Updating\.\.\. \[\d+\.\d+s\]\r\n`), "Quoted output: %q", stdout) | ||
| Expect(stdout.String()).To(MatchRegexp(`^{"level":"info","msg":"Updating..."}\n$`)) |
There was a problem hiding this comment.
nit: We could as well use Equal() here if we are gating the string between ^$.
There was a problem hiding this comment.
Nit rejected, it makes the test fail with a strange error (the strings are equal), probably whitespace related, but let's just leave it like this
Same for the others
| @@ -67,7 +67,7 @@ var _ = Describe("kraft version", func() { | |||
|
|
|||
| Expect(stderr.String()).To(BeEmpty()) | |||
| Expect(stdout.String()).To(MatchRegexp( | |||
| `^(level=error msg="unknown command "some-arg" for "kraft version"")|(unknown command "some-arg" for "kraft version")\n$`, | |||
| `^{"level":"error","msg":"unknown command \\"some-arg\\" for \\"kraft version\\""}\n$`, | |||
There was a problem hiding this comment.
nit: We could as well use Equal() here if we are gating the string between ^$.
| Expect(stderr.String()).To(BeEmpty()) | ||
|
|
||
| // Check warning message exists in stdout | ||
| Expect(stdout.String()).To(MatchRegexp(`^{"level":"warning","msg":"manifest already saved: https://manifests\.kraftkit\.sh/index\.yaml"}\n$`)) |
There was a problem hiding this comment.
nit: We could as well use Equal() here if we are gating the string between ^$.
| Expect(cfgMapUnikernelManifests[1]).To(Equal("https://example.com")) | ||
|
|
||
| // Check if stdout contains the warning message | ||
| Expect(stdout.String()).To(MatchRegexp(`^{"level":"warning","msg":"manifest already saved: https://example\.com"}\n$`)) |
There was a problem hiding this comment.
nit: We could as well use Equal() here if we are gating the string between ^$.
| Expect(cfgMapUnikernelManifests[0]).To(Equal("https://manifests.kraftkit.sh/index.yaml")) | ||
|
|
||
| // Check if stdout contains the warning | ||
| Expect(stdout.String()).To(MatchRegexp(`^{"level":"warning","msg":"manifest not found: https://example\.com"}\n$`)) |
There was a problem hiding this comment.
nit: We could as well use Equal() here if we are gating the string between ^$.
| Expect(cfgMapUnikernelManifests[1]).To(Equal("https://example3.com")) | ||
|
|
||
| // Check if stdout has a warning | ||
| Expect(stdout.String()).To(MatchRegexp(`^{"level":"warning","msg":"manifest not found: https://example2\.com"}\n$`)) |
There was a problem hiding this comment.
nit: We could as well use Equal() here if we are gating the string between ^$.
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/test-e2e-source-unsource
branch
from
cbb73ad
to
95e8aa6
Compare
antoineco
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
GitHub-Fixes: #735