-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): Add tests for the 'net' set of commands #826
feat(e2e): Add tests for the 'net' set of commands #826
Conversation
6a1639d
to
da62b36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments:
-
All these commands are intertwined inside the test suites.
inspect
depends onup
,down
andrm
for example. It seems like we could have easily covered most of them in a single suite. -
It would have been interesting to test that a unikernel can actually make use of the network created by those commands (e.g. nginx from our catalog).
Yes, for the first point, I wanted to use For the second point, it will surely be covered in the |
Regarding the first point, what I meant is that you could pretty much keep only the file that's currently called This is not a request for change btw, just an observation to reduce redundancy in the future. The code is written so let's keep it. |
da62b36
to
49656d8
Compare
Took a bit more to solve all stuff I now suffixed every set of commands with the command name. Should make things a bit less confusing + less chance for errors because input/output won't (potentially) spill between commands |
aaand tests fail now online |
and now they seem to pass, wut |
27803e4
to
aee1695
Compare
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
aee1695
to
e9a9fc6
Compare
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
e9a9fc6
to
9b0e0e2
Compare
Prerequisite checklist
make fmt
on your commit series before opening this PR;Description of changes
To run the tests you will need to be root or run with
sudo
because the commands manipulate network interfaces.Hopefully this works in the actions, otherwise we can just try to skip them in the action.