Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goreleaser): Suggest compiler packages for different arch cases #827

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

If someone with arm64 installs the kraftkit package they will only get the arm build tools through the recommended packages.
The main, most stable, target of Unikraft is still x86 so we add suggestions to explicitly install the toolchains for building x86_64 targets.

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc craciunoiuc added the kind/enhancement New feature or request label Sep 19, 2023
@craciunoiuc
Copy link
Member Author

It seems that to use this people need to have the --install-suggests added. Also the install script needs to be changed.

I can move this to recommends if you want

@craciunoiuc craciunoiuc requested review from antoineco and removed request for nderjung October 2, 2023 11:49
@craciunoiuc craciunoiuc assigned antoineco and unassigned nderjung Oct 2, 2023
@antoineco antoineco merged commit 5115b02 into unikraft:staging Oct 2, 2023
4 checks passed
@craciunoiuc craciunoiuc deleted the craciunoiuc/add-x86-tools branch October 17, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants