Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(webinstall): switch to distroless base image #831

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Sep 19, 2023

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Use gcr.io/distroless/static:nonroot as the container base image for the following reasons:

  • Already includes ca-certificates
  • Rootless by default
  • Enables the usage of secret injectors at runtime, which are often themselves injected as a static binary via Kubernetes mutating webhooks, and tend to fail if there is no basic directory structure inside the image (/tmp, ...)

Signed-off-by: Antoine Cotten <antoine@unikraft.io>
@antoineco antoineco changed the title chore(webinstall): switch to distroless base image build(webinstall): switch to distroless base image Sep 19, 2023
@antoineco antoineco closed this Sep 19, 2023
@antoineco antoineco reopened this Sep 19, 2023
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io

@craciunoiuc craciunoiuc self-assigned this Sep 20, 2023
@craciunoiuc craciunoiuc added the area/tools Issue or PR related to internal KraftKit tools label Sep 20, 2023
@craciunoiuc craciunoiuc merged commit e7b033f into unikraft:staging Sep 20, 2023
7 of 8 checks passed
@antoineco antoineco deleted the distroless branch September 20, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tools Issue or PR related to internal KraftKit tools
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants