fix(webinstall): Correct use of makepkg for Arch Linux
#838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderjung
changed the title
makepkg for Arch Linux
craciunoiuc
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Hey @SorenEricMent,
Thanks a lot for this fix. I left a comment for a change.
Also, can you change you commit message to have this format? Thanks
fix(webinstall): Correct use of `makepkg` for Arch Linux
|
Please also squash the 2 commits together and add the name above |
SorenEricMent
force-pushed
the
staging
branch
from
f3bb7bd
to
09c0cc1
Compare
Done! Sorry I was bit last, kinda busy with school stuff xx |
|
@SorenEricMent It's fine, no worries, but it seems you rebased one more commit and this PR now has two commits 😅 Can you drop the second to last one and leave only yours? Thanks 🙏 |
Signed-off-by: Yunchuan "Winslow" Hu i@winsloweric.com Fix makepkg for Archlinux Signed-off-by: Yunchuan "Winslow" Hu <i@winsloweric.com> Update tools/webinstall/install.sh Tested, totally work, thank you. Co-authored-by: Cezar Craciunoiu <craciunoiu.cezar@yahoo.com> Signed-off-by: WinslowEric <i@winsloweric.com>
|
Should be good to go! |
craciunoiuc
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;This change does not impact building, thus there is no need for running make fmt nor updating relevant documentation. This patch is Arch Linux platform specific.
Description of changes
Fixed makepkg command for ArchLinux, addressing issue #837
Signed-off-by: Yunchuan "Winslow" Hu i@winsloweric.com