feat(workflows): Add multi-os stable tests #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
added
kind/enhancement
craciunoiuc
force-pushed
the
craciunoiuc/thorough-e2e-tests-stable
branch
2 times, most recently
from
cb1f18c
to
0c9fcf3
Compare
|
Can we temporarily enable this workflow for this PR, just to at least ensure that it completes? Then we can revert back to only running on |
|
sure, we can remove it after it completes |
craciunoiuc
force-pushed
the
craciunoiuc/thorough-e2e-tests-stable
branch
from
0c9fcf3
to
5545251
Compare
|
Added, let's see |
craciunoiuc
force-pushed
the
craciunoiuc/thorough-e2e-tests-stable
branch
from
5545251
to
e31b409
Compare
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/thorough-e2e-tests-stable
branch
from
e31b409
to
4ea47da
Compare
antoineco
approved these changes
Sep 27, 2023
craciunoiuc
force-pushed
the
craciunoiuc/thorough-e2e-tests-stable
branch
from
4ea47da
to
16d6eb4
Compare
nderjung
reviewed
Sep 27, 2023
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/thorough-e2e-tests-stable
branch
from
16d6eb4
to
75118f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This adds testing when pushing to stable on all OSes available through GitHub on Linux and Mac.
Of course we should catch this before pushing to stable, but it will take A Lot of time ti run all those so it's better if we only do it ~once a week.
I only copied the existing tests and added some duplication + matrixes.