fix(internal): Attribute CLI flags after reading config #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
added
kind/fix
craciunoiuc
force-pushed
the
craciunoiuc/fix-cli-flag-attr
branch
2 times, most recently
from
12c2916
to
9eec79c
Compare
jake-ciolek
approved these changes
Oct 3, 2023
craciunoiuc
force-pushed
the
craciunoiuc/fix-cli-flag-attr
branch
from
9eec79c
to
1fcafe0
Compare
nderjung
reviewed
Oct 3, 2023
nderjung
reviewed
Oct 3, 2023
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/fix-cli-flag-attr
branch
from
1fcafe0
to
01c6eaf
Compare
nderjung
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Awesome thanks!
Reviewed-by: Alexander Jung alex@unikraft.io
Approved-by: Alexander Jung alex@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Because we read the config file at a path, the previously read CLI flags were overwritten. To fix we attribute the flags again over the newly-read config.