Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): Fully clone the Git repository #890

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

nderjung
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Since pflag nor cobra expose these flags such that they return the
`*pflag.Flag` struct independently, we create our own.

Signed-off-by: Alexander Jung <alex@unikraft.io>
@nderjung nderjung force-pushed the nderjung/fix/manifest/full-clone branch 2 times, most recently from 4609afd to 60df029 Compare October 19, 2023 14:17
Signed-off-by: Alexander Jung <alex@unikraft.io>
@nderjung nderjung force-pushed the nderjung/fix/manifest/full-clone branch from 60df029 to 112a7c4 Compare October 19, 2023 14:19
@antoineco antoineco merged commit dc80d9c into unikraft:staging Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants