feat(github-action): Upgrade GitHub Actions #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderjung
force-pushed
the
nderjung/feat/tools/github-action/upgrade
branch
3 times, most recently
from
75d5e91
to
74f7dd6
Compare
craciunoiuc
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Included are necessary changes to makae the github-action compatible. Also remove the `replace` statement. Signed-off-by: Alexander Jung <alex@unikraft.io>
Allow for authenticated calls during the pulling processs. Signed-off-by: Alexander Jung <alex@unikraft.io>
Signed-off-by: Alexander Jung <alex@unikraft.io>
Signed-off-by: Alexander Jung <alex@unikraft.io>
Signed-off-by: Alexander Jung <alex@unikraft.io>
Signed-off-by: Alexander Jung <alex@unikraft.io>
Signed-off-by: Alexander Jung <alex@unikraft.io>
This commit fixes the GitHub Actions workflow for the github-actions program. Previously, the integration would not be properly run, in fact it was running what was already in the registry. Solve this by not "load"ing the image (this unintuitive name does the opposite of what we want) so that we can use the image locally. Additionally, do not run the pull step in the action; this will be done if the image is not present by the run step. Signed-off-by: Alexander Jung <alex@unikraft.io>
Signed-off-by: Alexander Jung <alex@unikraft.io>
nderjung
force-pushed
the
nderjung/feat/tools/github-action/upgrade
branch
from
74f7dd6
to
42ea39e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This PR upgrades the GitHub action to a newer version of KraftKit and makes necessary additional adjustments, including: