Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oci): Use auth when provided #892

Merged

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@nderjung
Copy link
Member

nderjung commented Oct 19, 2023

Maybe it makes sense to still do defaultAuths and then overwrite with whatever is provided by the query?

If the user is setting auths, we should respect that.

@nderjung nderjung merged commit ba4d382 into unikraft:staging Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants