fix(pkg): Handle single-target runtimes repackaging #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where a user would run `kraft pkg` with using a `Kraftfile` that uses the `runtime` element and the `runtime` element returns from the `Catalog` a single target. Previously, the host platform and architecture were used when they were unset at the commandline and set to the host's platform and architecture. Instead, query the catalog without these set and check if only a single entry is returned. If it does, the user only wants to re-package this. If we get more options then use the host architecture and platform and re-query the catalog. Signed-off-by: Alexander Jung <alex@unikraft.io>
craciunoiuc
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This commit fixes an issue where a user would run
kraft pkgwith using aKraftfilethat uses theruntimeelement and theruntimeelement returns from theCataloga single target. Previously, the host platform and architecture were used when they were unset at the commandline and set to the host's platform and architecture. Instead, query the catalog without these set and check if only a single entry is returned. If it does, the user only wants to re-package this. If we get more options then use the host architecture and platform and re-query the catalog.