feat(list): Reduce output and provide --all flag to extend it
#945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reworks the query to the `Catalog` method such that the host's platform and architecture are incorporated by default. This reduces the output, especially with the OCI package manager's catalog which has an increased list of applications but these vary by architecture and platform. To show everything, however, introduce an `--all` flag. This means that if you want to see OCI applications in the remote registry which are applicable to your host, you simply invoke: ```console kraft pkg ls --apps --update ``` To view all variants of the same application, now include the `--all` flag: ```console kraft pkg ls --apps --update --all ``` Signed-off-by: Alexander Jung <alex@unikraft.io>
nderjung
force-pushed
the
nderjung/feat/internal/cli/kraft/pkg/update/all-arch-plat
branch
from
8a9a935
to
8195d39
Compare
craciunoiuc
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This commit reworks the query to the
Catalogmethod such that the host's platform and architecture are incorporated by default. This reduces the output, especially with the OCI package manager's catalog which has an increased list of applications but these vary by architecture and platform.To show everything, however, introduce an
--allflag. This means that if you want to see OCI applications in the remote registry which are applicable to your host, you simply invoke:kraft pkg ls --apps --updateTo view all variants of the same application, now include the
--allflag:kraft pkg ls --apps --update --all