Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg): Introduce --push flag #946

Conversation

nderjung
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

This commit introduces a new flag to kraft pkg, --push, which, upon successful packaging pushes the resulting artifacts.

This commit introduces a new flag to `kraft pkg`, `--push`, which, upon
successful packaging pushes the resulting artifacts.

Signed-off-by: Alexander Jung <alex@unikraft.io>
@nderjung nderjung force-pushed the nderjung/feat/internal/cli/kraft/pkg/push-flag branch from 8f45ae2 to 1767979 Compare October 26, 2023 16:57
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io

@craciunoiuc craciunoiuc merged commit 0d09e39 into unikraft:staging Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants