Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oci)!: Expose index and manifest digests of OCI package columns #960

Conversation

nderjung
Copy link
Member

@nderjung nderjung commented Nov 1, 2023

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Rename the digest column to the more accurate name manifest of which the digest represented. Also add the index manifest to help users identify the index with which this package is a member of.

GitHub-Depends-On: #959

Rename the `digest` column to the more accurate name `manifest` of which
the digest represented.  Also add the index manifest to help users
identify the index with which this package is a member of.

GitHub-Depends-On: unikraft#959
Signed-off-by: Alexander Jung <alex@unikraft.io>
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io

@craciunoiuc craciunoiuc merged commit edb2ffd into unikraft:staging Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants