Split off functionality that relies on libm #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested review from
eduardvintila
and removed request for
mariasfiraiala
StefanJum
reviewed
Aug 7, 2023
There was a problem hiding this comment.
This looks fine @andreittr, thank you.
allowing a minimal compiler-rt to be built with nolibc alone What is the minimal setup for building compiler-rt with this pr? I suppose libunwind it's still needed, right?
Previously some parts of compiler-rt depended on functions provided by a math library, commonly supplied together with a real libc. This change sections off the parts dependent on libm, allowing a minimal compiler-rt to be built with nolibc alone. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/split-math
branch
from
3b76b0c
to
8052e81
Compare
Nope, following the merging of #14 libunwind is no longer needed, except if you really want that gcc_personality_v0. A plainly configured also: rebased on top of staging, fixed conflicts & re-pushed. |
StefanJum
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Thank you @andreittr, all good.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously some parts of compiler-rt depended on functions provided by a math library, commonly supplied together with a real libc. This change sections off the parts dependent on libm, allowing a minimal compiler-rt to be built with nolibc alone.