build: Split off functionality that depends on libunwind #14
Conversation
There was a problem hiding this comment.
@andreittr I don't know how related to this pr this is, but it seems that compiler-rt relies on musl, as it looks for float.h, so we should add that as a dependency.
Everything else looks good, so if you think we should do that in another PR we can merge this.
Good catch; looking through the code I think the right course of action is to add in float.h as part of nolibc as opposed to mandating musl (or any other libc). This is because float.h only defines some useful float constants and is usually provided along with other compiler headers, not tied to a particular libc. |
|
On closer inspection it seems compiler-rt requires a math library (in addition to some convenience headers) in order to successfully build. Will look into what the best way to proceed, either depend on (or check for) a real libc, or further split off maths functionality, and handle the issue in a separate PR. |
|
Update: the implicit dependency on a real libc has been fixed with these 2 PRs: As soon as these are merged, this PR should be rebased on top. |
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
Good addition, thanks.
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
Previously lib-compiler-rt depended on libunwind as it pulled in <unwind.h>; this dependency however is isolated in gcc_personality_v0.c. This change makes gcc personality an optional part of lib-compiler-rt, allowing it to be built without an entire supporting C++ runtime. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/split-cxx
branch
from
006f763
to
b5b1cf8
Compare
Previously lib-compiler-rt depended on libunwind as it pulled in <unwind.h>; this dependency however is isolated in gcc_personality_v0.c. This change makes gcc personality an optional part of lib-compiler-rt, allowing it to be built without an entire supporting C++ runtime.
This will allow lib-compiler-rt to be minimally pulled in when the compiler emits calls to builtin functions e.g., as discussed in unikraft/lib-musl#46.
Tested on qemu-kvm-x86_64 with GCC 13 and clang 16.