Makefile.uk: Remove redundant check for libunwind #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b5b1cf8 (Split off functionality that depends on libunwind) removed the cyclic dependency between libunwind and libcompiler-rt and correctly expressed the relationship through Kconfig, making the build-time check for libunwind in Makefile.uk redundant. This change removes said redundant check. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
StefanJum
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
eduardvintila
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
razvand
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b5b1cf8 (Split off functionality that depends on libunwind) removed the cyclic dependency between libunwind and libcompiler-rt and correctly expressed the relationship through Kconfig, making the build-time check for libunwind in Makefile.uk redundant. This change removes said redundant check.