patches: Include the first stddef header file #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
added
bug
StefanJum
changed the title
StefanJum
force-pushed
the
change-include-next
branch
from
64d906a
to
83268f5
Compare
mariasfiraiala
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Looks good. Tested it on both x86 and AArch64 with helloworld-cpp and it behaved just fine.
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
When using Musl, the build breaks because the `include_next` cannot find a new `stddef.h` header file. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
change-include-next
branch
from
83268f5
to
6e3778f
Compare
razvand
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Thanks, @StefanJum
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Musl, the build breaks because the
include_nextcannot find a newstddef.hheader file.
This is just a hack to go around it and include
the Musl
stddef.hfile, we should find aproper sollution to this.
Related to: #12
Signed-off-by: Stefan Jumarea stefanjumarea02@gmail.com