Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structure member naming in patches #5

Closed
wants to merge 1 commit into from

Conversation

panagiotiskon
Copy link

@panagiotiskon panagiotiskon commented Mar 31, 2023

Signed-off-by: panagiotis <panos.kontoeidis@gmail.com>
@razvand razvand self-requested a review April 16, 2023 12:26
@razvand razvand self-assigned this Apr 16, 2023
@razvand razvand added enhancement New feature or request bug Something isn't working labels Apr 16, 2023
@razvand
Copy link
Contributor

razvand commented Apr 16, 2023

@panagiotiskon, how did you test your change?

@razvand
Copy link
Contributor

razvand commented Apr 16, 2023

@panagiotiskon, how did you test your change?

Got it, you used PR #6 for app-lua.

@razvand
Copy link
Contributor

razvand commented Apr 16, 2023

@panagiotiskon, please improve your PR to feature your full name to the author name and the Signed-off-by message. Also, detail the commit is required to synchronize with the uk_memory_descriptor structure from Unikraft core.

@razvand
Copy link
Contributor

razvand commented Oct 1, 2023

Closing this, as the patch was removed by #8 .

@razvand razvand closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants