patches: Remove outdated patch #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
reviewed
Jul 18, 2023
There was a problem hiding this comment.
Thanks, @StefanJum , this works, in conjunction to PR #7. Once @eduardvintila does his review, I will approve it to have it merged.
eduardvintila
requested changes
Jul 18, 2023
There was a problem hiding this comment.
This is great, @StefanJum, thank you. You know what's greater? This typo from the last phrase of your commit message: regardell of the fs dreiver 😁
The patch was: * Replacing the lua `main` symbol with `lua_main`. * Removing checking that the given argument was a script, instead checking if there is an initrd filesystem present and trying to execute it. The `main` symbol is already replaced in the preprocessing stage by adding `-Dmain=lua_main` in the `Makefile.uk` flags, so renaming it is not needed. Trying to execute the initrd without properly extracting it will obviously fail, since `lua` will not be able to read the script properly. This will result in an `malformed number near '0707010..'` error. The check for initrd is not needed at all, since the fs driver is transparent for the application, and the script can be accessed as an usual file, regardless of the fs driver (initrd, 9pfs, etc.). Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/remove-faulty-patch
branch
from
ce6c501
to
4eb4e7d
Compare
Wow that was a bad one, fixed 😆 |
eduardvintila
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
All good now 😬 , thanks!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
razvand
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch was:
mainsymbol withlua_main.checking if there is an initrd filesystem present and trying to
execute it.
The
mainsymbol is already replaced in the preprocessing stage byadding
-Dmain=lua_mainin theMakefile.ukflags, so renaming it isnot needed.
Trying to execute the initrd without properly extracting it will
obviously fail, since
luawill not be able to read the script properly.This will result in an
malformed number near '0707010..'error.The check for initrd is not needed at all, since the fs driver is
transparent for the application, and the script can be accessed as an
usual file, regardell of the fs dreiver (initrd, 9pfs, etc.).
app-luacan be run with a script as an argument with one of the following:Signed-off-by: Stefan Jumarea stefanjumarea02@gmail.com