Various fixes #41
Closed
Various fixes #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `fetch` was not really a file, make always tried to remake the version file. Therefore, it also needed to recompile the file as the mtime of the version file was updated. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
While musl doesn't provide an actual implementation for the legacy ucontext API, the header is still useful to compile software against musl. Also, some software only relies on the definitions in the header. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
This header is deprecated but sometimes still used by software. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
The signals are currently ignored and that causes musl to `exit` the thread, which doesn't cause any output. Therefore, it's very unclear what happened. By calling `UK_CRASH` there is a clear indication that something went wrong. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
On clang, this statement caused compiler errors instead of only warnings. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mogasergiu
reviewed
Apr 27, 2023
The `sys/resource.h` header adds #define-based redirection from `prlimit64` to `prlimit` when `_GNU_SOURCE` is set. This causes our `provided_syscalls` to incorrectly define `uk_syscall_r_prlimit` instead of `uk_syscall_r_prlimit64`. By reordering, the headers we can side-step this problem. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
The real one provided in `mprotect.c` works with the `mprotect` system call introduced with the posix-mmap library. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
If these fields are not initialized as expected by musl, then calls to pthread functions such `pthread_getspecific` can return unexpected values or even crash. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
mschlumpp/fix/compat
branch
from
0fb76c1
to
814cc2a
Compare
eduardvintila
approved these changes
May 1, 2023
There was a problem hiding this comment.
Great fixes, @mschlumpp!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
mogasergiu
approved these changes
May 1, 2023
There was a problem hiding this comment.
Forgot to add the RB :). LGTM.
Reviewed-by: Sergiu Moga sergiu.moga@protonmail.com
razvand
approved these changes
May 4, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
May 4, 2023
While musl doesn't provide an actual implementation for the legacy ucontext API, the header is still useful to compile software against musl. Also, some software only relies on the definitions in the header. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #41
unikraft-bot
pushed a commit
that referenced
this pull request
May 4, 2023
This header is deprecated but sometimes still used by software. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #41
unikraft-bot
pushed a commit
that referenced
this pull request
May 4, 2023
The signals are currently ignored and that causes musl to `exit` the thread, which doesn't cause any output. Therefore, it's very unclear what happened. By calling `UK_CRASH` there is a clear indication that something went wrong. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #41
unikraft-bot
pushed a commit
that referenced
this pull request
May 4, 2023
On clang, this statement caused compiler errors instead of only warnings. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #41
unikraft-bot
pushed a commit
that referenced
this pull request
May 4, 2023
The `sys/resource.h` header adds #define-based redirection from `prlimit64` to `prlimit` when `_GNU_SOURCE` is set. This causes our `provided_syscalls` to incorrectly define `uk_syscall_r_prlimit` instead of `uk_syscall_r_prlimit64`. By reordering, the headers we can side-step this problem. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #41
unikraft-bot
pushed a commit
that referenced
this pull request
May 4, 2023
The real one provided in `mprotect.c` works with the `mprotect` system call introduced with the posix-mmap library. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #41
unikraft-bot
pushed a commit
that referenced
this pull request
May 4, 2023
If these fields are not initialized as expected by musl, then calls to pthread functions such `pthread_getspecific` can return unexpected values or even crash. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of smaller fixes that accumulated over time. See the respective commits for a description and explanation of the changes.