Makefile.uk: Silence warnings #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
This commit changes several warning flags: -Wno-error=sign-compare removed -Wno-unused-value relegated to the glue code -Wno-cast-function-type is sent to clang as well as GCC -Wno-macro-redefined and -Wno-string-plus-int added for clang -Wno-unused added for the entire library -K&R-style declaration warnings silenced by -Wno-old-style-declaration (GCC) or -Wno-deprecated-non-prototype (clang) -Wno-unused-command-line-argument to silence assembler Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Set warning flags only if the current clang version supports them. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
razvand
approved these changes
Aug 7, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Set warning flags only if the current clang version supports them. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes several warning flags:
-Wno-error=sign-compare removed
-Wno-unused-value relegated to the glue code
-Wno-cast-function-type is sent to clang as well as GCC -Wno-macro-redefined and -Wno-string-plus-int added for clang -Wno-unused added for the entire library
-K&R-style declaration warnings silenced by -Wno-old-style-declaration (GCC) or -Wno-deprecated-non-prototype (clang)
-Wno-unused-command-line-argument to silence assembler
Also sets warning flags only if supported by the clang version in use; depends on PR#983.