-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add compiler version checking for Clang #983
Conversation
@andreittr I think this will be covered by #944 |
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @andreittr . This looks good. My only comment would be using capitalized Clang
in your commit message.
@StefanJum , yes, it makes sense. Let's merge this and then have #944 rebased on top of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreittr can you please also add a error_if_clang_version_lt
, similar to what we have for gcc
?
This change adds version checking make functions in line with what we have already for GCC. Also added are *_lt functions that check for a maximum compiler version. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Description of changes
This change adds version checking make functions in line with what we have already for GCC.
Also added are
*_lt
functions that check for a maximum compiler version.Prerequisite checklist
checkpatch.uk
on your commit series before opening this PR;Base target
Additional configuration
N/A
Edit: rebased & addressed comments.