Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add compiler version checking for Clang #983

Closed
wants to merge 1 commit into from

Conversation

andreittr
Copy link
Contributor

@andreittr andreittr commented Jul 19, 2023

Description of changes

This change adds version checking make functions in line with what we have already for GCC.
Also added are *_lt functions that check for a maximum compiler version.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): N/A
  • Platform(s): N/A
  • Application(s): N/A

Additional configuration

N/A

Edit: rebased & addressed comments.

@StefanJum
Copy link
Member

@andreittr I think this will be covered by #944

@unikraft-bot
Copy link
Member

Checkpatch passed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request and it all looks good!

SHA commit checkpatch
9ed8da6 build: Add compiler version checking for clang

@razvand razvand requested review from StefanJum and mariasfiraiala and removed request for craciunoiuc July 24, 2023 19:30
@razvand razvand assigned razvand and unassigned nderjung Jul 24, 2023
@razvand razvand removed the request for review from a team July 24, 2023 19:30
@razvand razvand added kind/enhancement New feature or request area/makefile Part of the Unikraft Makefile build system topic/build Topics to do with the build system labels Jul 24, 2023
@razvand razvand added this to the v0.14.0 (Prometheus) milestone Jul 24, 2023
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @andreittr . This looks good. My only comment would be using capitalized Clang in your commit message.

@StefanJum
Copy link
Member

@razvand do we go for this and have #944 rebased on top?
The compiler version checking is also done by that one (see the comment above).

@razvand
Copy link
Contributor

razvand commented Jul 24, 2023

@StefanJum , yes, it makes sense. Let's merge this and then have #944 rebased on top of this.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreittr can you please also add a error_if_clang_version_lt, similar to what we have for gcc?

This change adds version checking make functions in line with what we
have already for GCC. Also added are *_lt functions that check for a
maximum compiler version.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
@andreittr andreittr changed the title build: Add compiler version checking for clang build: Add compiler version checking for Clang Jul 25, 2023
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@unikraft-bot unikraft-bot added the ci/merged Merged by CI label Jul 27, 2023
@andreittr andreittr deleted the ttr/cc-ge branch August 11, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/makefile Part of the Unikraft Makefile build system ci/merged Merged by CI kind/enhancement New feature or request topic/build Topics to do with the build system
Projects
Status: Done
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

5 participants