Makefile.uk: Include missing cpow* functions #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
suggested changes
Aug 6, 2023
There was a problem hiding this comment.
@andreittr I get the following errors when building with the musl-complex library enabled:
/usr/bin/ld: workdir/apps/nginx/build/libmusl.o: in function `cpow':
workdir/apps/nginx/build/libmusl/origin/musl-1.2.3//src/complex/cpow.c:7: undefined reference to `__muldc3'
/usr/bin/ld: workdir/apps/nginx/build/libmusl.o: in function `cpowf':
workdir/apps/nginx/build/libmusl/origin/musl-1.2.3//src/complex/cpowf.c:5: undefined reference to `__mulsc3'
/usr/bin/ld: workdir/apps/nginx/build/libmusl.o: in function `cpowl':
workdir/apps/nginx/build/libmusl/origin/musl-1.2.3//src/complex/cpowl.c:11: undefined reference to `__mulxc3'
Is there anything I'm missing?
These functions are emitted by the compiler and implemented in |
The complex number library was previously missing the implementation of cpow* functions. This change corrects this omission. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Yes, it happens on |
The cpow* functions provided by libcomplex make use of the `__mul?c3` functions, implemented by libcompiler-rt, when building with either Clang or GCC. Therefore, this change makes musl unconditionally select libcompiler-rt when building libcomplex. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Updated w/ new commit; had libcomplex select compiler-rt. |
StefanJum
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
All good, thank you.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Aug 9, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
The cpow* functions provided by libcomplex make use of the `__mul?c3` functions, implemented by libcompiler-rt, when building with either Clang or GCC. Therefore, this change makes musl unconditionally select libcompiler-rt when building libcomplex. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #64
This was referenced Aug 9, 2023
nderjung
added a commit
to nderjung/unikraft
that referenced
this pull request
Aug 9, 2023
Following the merge of [0], the use of complex numbers requires the external microlibrary `compiler-rt`[1]. Without this inclusion, builds that set `CONFIG_LIBMUSL_COMPLEX` will fail. [0]: unikraft/lib-musl#64 [1]: https://github.com/unikraft/lib-compiler-rt Signed-off-by: Alexander Jung <alex@unikraft.io>
unikraft-bot
pushed a commit
to unikraft/unikraft
that referenced
this pull request
Aug 9, 2023
Following the merge of [0], the use of complex numbers requires the external microlibrary `compiler-rt`[1]. Without this inclusion, builds that set `CONFIG_LIBMUSL_COMPLEX` will fail. [0]: unikraft/lib-musl#64 [1]: https://github.com/unikraft/lib-compiler-rt Signed-off-by: Alexander Jung <alex@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #1033
craciunoiuc
pushed a commit
to unikraft-bananatree/unikraft
that referenced
this pull request
Mar 26, 2024
Following the merge of [0], the use of complex numbers requires the external microlibrary `compiler-rt`[1]. Without this inclusion, builds that set `CONFIG_LIBMUSL_COMPLEX` will fail. [0]: unikraft/lib-musl#64 [1]: https://github.com/unikraft/lib-compiler-rt Signed-off-by: Alexander Jung <alex@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #1033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complex number library was previously missing the implementation of cpow* functions. This change corrects this omission.