Port upstream Pillow 10.0.0 #1
Conversation
Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This work is based off Pillow 10.0.0 configured on Linux x86_64 and adapted to work with Unikraft. Files under importfix/ are correctly namespaced wrapper modules for any binary modules that we compile and link into Unikraft, and must be copied over to the python rootfs. Selecting this library will add its files to the python rootfs build. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
razvand
requested review from
RaduNichita and
mariasfiraiala
and removed request for
RaduNichita
There was a problem hiding this comment.
Thanks for this @andreittr. Before starting testing, how would a Makefile with all the dependencies look like for pillow? I am mostly interested in the correct order of the libraries.
Whoops, my bad, updated now. The order isn't strictly nailed down, it's just the one I was using during dev. You could likely mix them up as long as dependencies appear before the libs using them. I tried to be fairly paranoid about include paths not breaking. |
|
@andreittr any idea why I get this? |
@StefanJum I believe you need this PR unikraft/lib-python-numpy#2 to solve those numpy include shenanigans; I had mentioned it among other fix PRs in unikraft/lib-python3#22 but forgot to add them to this PR as well, whoops. |
There was a problem hiding this comment.
All good.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
Works great, thanks!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1
This work is based off Pillow 10.0.0 configured on Linux x86_64 and adapted to work with Unikraft. Files under importfix/ are correctly namespaced wrapper modules for any binary modules that we compile and link into Unikraft, and must be copied over to the python rootfs. Selecting this library will add its files to the python rootfs build. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1
This work is based off Pillow 10.0.0 configured on Linux x86_64 and adapted to work with Unikraft.
Files under importfix/ are correctly namespaced wrapper modules for any binary modules that we compile and link into Unikraft, and must be copied over to the python rootfs.
Selecting this library will add its files to the python rootfs build.
This depends on, or integrates with, the following PRs:
Makefile library inclusion order (x86, replace intrinsics with appropriate arm ones if on arm):