Add support for the Pillow extension #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreittr
requested review from
StefanJum
and removed request for
StefanJum
This change only adds the necessary module registrations and Kconfig options. Pillow itself is provided by its own Unikraft port. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Previously Makefile.uk used `python` and `python3` interchangeably which caused unexpected issues on misconfigured systems where these two do not point to the same binary. This change fixes this oversight by using `python` everywhere. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/py310-pillow
branch
from
35d4bc5
to
ee4a0a2
Compare
StefanJum
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
RaduNichita
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
All good from my side, many thanks @andreittr
Reviewed-by: Radu Nichita radunichita99@gmail.com
razvand
approved these changes
Oct 16, 2023
razvand
pushed a commit
that referenced
this pull request
Oct 16, 2023
This change only adds the necessary module registrations and Kconfig options. Pillow itself is provided by its own Unikraft port. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #22
razvand
pushed a commit
that referenced
this pull request
Oct 16, 2023
Previously Makefile.uk used `python` and `python3` interchangeably which caused unexpected issues on misconfigured systems where these two do not point to the same binary. This change fixes this oversight by using `python` everywhere. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only adds the necessary module registrations and Kconfig options. Pillow itself is provided by its own Unikraft port.
In addition, contains a hotfix commit to consistently use
pythonwhen building the rootfs (instead of a mix ofpythonandpython3).Depends on the Pillow port PR:
as well as all of its dependencies and interactions.
May also depend on:
mmapstdlib module #20Running the Pillow tests:
pytestin rootfs (via venv + pip)$(BUILD_DIR)/lib-python-pillow/origin/Pillow-10.0.0/Testsover into the rootfs-m pytest Tests/with plenty of allocated VM RAM