Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system_off to include the shutdown cause #1018

Closed
nderjung opened this issue Aug 3, 2023 · 0 comments
Closed

Update system_off to include the shutdown cause #1018

nderjung opened this issue Aug 3, 2023 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@nderjung
Copy link
Member

nderjung commented Aug 3, 2023

Feature request summary

This issue tracks adding a shutdown cause to system_off in order to properly propagate an error code following a VM EXIT.

This is useful in contexts where the returning code is used to determine whether the execution of a unikernel image was successful. For example, in a CI/CD context and a run-to-completion-type unikernel, i.e. one that runs the internal test suite, is executed. If test failures occur, a non-zero error code should be propagated via a return code which will ultimately become visible through the CI/CD software. In Unikraft's case, this is will be shown in incoming PRs.

Describe alternatives

No response

Related architectures

None

Related platforms

None

Additional context

No response

@nderjung nderjung added the kind/enhancement New feature or request label Aug 3, 2023
@mschlumpp mschlumpp linked a pull request Aug 3, 2023 that will close this issue
4 tasks
mschlumpp added a commit to mschlumpp/unikraft that referenced this issue Aug 3, 2023
This uses the `isa-debug-exit` device to pass an exit code to QEMU. By
default this device is not available but can be enabled using the
`-device isa-debug-exit` switch on the QEMU command-line.

Github-Fixes: unikraft#1018
Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp added a commit to mschlumpp/unikraft that referenced this issue Aug 3, 2023
This uses the `isa-debug-exit` device to pass an exit code to QEMU. By
default this device is not available but can be enabled using the
`-device isa-debug-exit` switch on the QEMU command-line.

Github-Fixes: unikraft#1018
Signed-off-by: Marco Schlumpp <marco@unikraft.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant