plat/*: Signal shutdown cause on QEMU #1019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschlumpp
force-pushed
the
mschlumpp/fix/qemu-exit-code
branch
from
20c5662
to
7594d1a
Compare
razvand
added
plat/kvm
razvand
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Hi, @mschlumpp, this looks good. Lemme test it. I left some minor comments.
plat/common/x86/cpu_native.c
Outdated
| */ | ||
| static void qemu_debug_exit(int value) | ||
| { | ||
| outw(0x501, value); |
There was a problem hiding this comment.
Would it make sense to have a macro for 0x501 - this doesn't tell me anything?
plat/common/x86/cpu_native.c
Outdated
| * will be 85 ('S', 42 << 1 | 1). | ||
| */ | ||
| if (request == UKPLAT_CRASH) | ||
| qemu_debug_exit(42); |
There was a problem hiding this comment.
Would it make sense to have a macro for 42 - this doesn't tell me anything? Why 42? What magic is this?
plat/common/x86/cpu_native.c
Outdated
| */ | ||
| outw(0x501, 41); | ||
| qemu_debug_exit(41); |
There was a problem hiding this comment.
Would it make sense to have a macro for 41 - this doesn't tell me anything? Why 41? What magic is this?
|
@razvand thinks he can hear what numbers say to him, it's that bad |
This uses the `isa-debug-exit` device to pass an exit code to QEMU. By default this device is not available but can be enabled using the `-device isa-debug-exit` switch on the QEMU command-line. Github-Fixes: unikraft#1018 Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
mschlumpp/fix/qemu-exit-code
branch
from
7594d1a
to
def271c
Compare
unikraft-bot
added
arch/arm
arch/arm64
area/plat
mogasergiu
approved these changes
Aug 3, 2023
razvand
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Thanks, @mschlumpp.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64kvmAdditional configuration
Description of changes
This uses the
isa-debug-exitdevice to pass an exit code to QEMU. By default this device is not available but can be enabled using the-device isa-debug-exitswitch on the QEMU command-line.@craciunoiuc @nderjung