Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove code under #ifndef CONFIG_PARAVIRT #27

Closed
felipehuici opened this issue Oct 15, 2019 · 2 comments
Closed

remove code under #ifndef CONFIG_PARAVIRT #27

felipehuici opened this issue Oct 15, 2019 · 2 comments
Labels
good-first-issue Good for newcomers kind/enhancement New feature or request
Projects
General Kanban

Comments

@felipehuici
Copy link
Member

We inherited bits of PVH code from Minios. The problem is this code did not work even for Minios. There is little point in keeping these bits. However it might be good to keep the -DCONFIG_PARAVIRT, as hints for future
@felipehuici felipehuici added kind/enhancement New feature or request good-first-issue Good for newcomers labels Oct 15, 2019
@jenchen18
Copy link

Hi, I'm a student taking a virtualization class at UT Austin, and I'm currently collaborating with one other. @felipehuici Is it possible that we can get more information about this issue if it's still available?

maruthgoyal added a commit to maruthgoyal/unikraft that referenced this issue Dec 11, 2020
@maruthgoyal
removing #ifndef CONFIG_PARAVIRT code: unikraft#27
258b9b8
@unikraft-bot unikraft-bot mentioned this issue Dec 12, 2020
Closed
@nderjung nderjung added this to TODO in General Kanban May 10, 2021
@StefanJum StefanJum mentioned this issue May 21, 2022
Closed
4 tasks
@marcrittinghaus
Copy link
Member

Issue solved with aforementioned PRs.

eduardvintila pushed a commit to eduardvintila/unikraft_riscv64 that referenced this issue Jul 28, 2023
@razvand @unikraft-bot
Makefile.uk: Use -Wno-cast-function-type for GCC >= 8
481df35 
The build option `-Wno-cast-function-type`, used in `Makefile.uk` is
available from GCC >= 8. When used in GCC <= 7, it issues a warning.

This commit updates the build flags to enable `-Wno-cast-function-type`
only when using GCC >= 8.

GitHub-Fixes: unikraft#27

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: unikraft#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers kind/enhancement New feature or request
Projects
No open projects
General Kanban
  
TODO
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felipehuici @marcrittinghaus @jenchen18