plat/xen: remove #ifndef CONFIG_PARAVIRT code

[maruthgoyal]

No description provided.

[nderjung]

Hi!

Thanks for the PR to solve #27. It looks like you've included changes which also do heavy reformats which are not in the scope of removing compile-time CONFIG_PARAVIRT blocks which subsequently give warnings from the checkpatch tool.

Could you please force-push to this branch (and PR) which only make these following changes or create separate commits which do correct refactors. Also don't forget to Signed-off-by: ;)

Thanks!

[unikraft-bot]

❗ Checkpatch failed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request but it encountered errors:

SHA	commit	checkpatch
258b9b8	removing #ifndef CONFIG_PARAVIRT code: #27	❌

Truncated logs starting from first error 258b9b8:

WARNING:SPLIT_STRING: quoted string split across lines
#551: FILE: plat/xen/x86/mm.c:81:
+	uk_pr_debug("Allocating new L%lu pt frame for pfn=%lx, "
+		    "prev_l_mfn=%lx, offset=%lx\n",

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#558: FILE: plat/xen/x86/mm.c:85:
+	/* We need to clear the page, otherwise we might fail to map it
+	   as a page table page */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#558: FILE: plat/xen/x86/mm.c:85:
+	   as a page table page */

WARNING:SPLIT_STRING: quoted string split across lines
#604: FILE: plat/xen/x86/mm.c:105:
+		UK_CRASH("PTE for new page table page could not be updated: "
+			 "mmu_update failed with rc=%d\n",

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#648: FILE: plat/xen/x86/mm.c:137:
+	/* Be conservative: even if we know there will be more pages already
+	   mapped, start the loop at the very beginning. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#648: FILE: plat/xen/x86/mm.c:137:
+	   mapped, start the loop at the very beginning. */

WARNING:SPLIT_STRING: quoted string split across lines
#667: FILE: plat/xen/x86/mm.c:143:
+		uk_pr_warn("Trying to use Xen virtual space. "
+			   "Truncating memory from %luMB to ",

WARNING:SPLIT_STRING: quoted string split across lines
#792: FILE: plat/xen/x86/mm.c:209:
+				UK_CRASH("PTE could not be updated. "
+					 "mmu_update failed with rc=%d\n",

WARNING:SPLIT_STRING: quoted string split across lines
#828: FILE: plat/xen/x86/mm.c:348:
+	uk_pr_debug("Mapping va=%p n=%lu, mfns[0]=0x%lx stride=%lu incr=%lu "
+		    "prot=0x%lx\n",

WARNING:SPLIT_STRING: quoted string split across lines
#949: FILE: plat/xen/x86/mm.c:528:
+				uk_pr_err("update_va_mapping failed for with "
+					  "rc=%d.\n",

WARNING:LINE_SPACING: Missing a blank line after declarations
#1108: FILE: plat/xen/x86/mm.c:615:
+		int count;
+		HYPERVISOR_mmuext_op(&op, 1, &count, DOMID_SELF);

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1253: FILE: plat/xen/x86/traps.c:51:
+    TRAP_TABLE_ENTRY(divide_error, 0), TRAP_TABLE_ENTRY(debug, 0),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1254: FILE: plat/xen/x86/traps.c:52:
+    TRAP_TABLE_ENTRY(int3, 3),^I       TRAP_TABLE_ENTRY(overflow, 3),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1255: FILE: plat/xen/x86/traps.c:53:
+    TRAP_TABLE_ENTRY(bounds, 3),       TRAP_TABLE_ENTRY(invalid_op, 0),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1256: FILE: plat/xen/x86/traps.c:54:
+    TRAP_TABLE_ENTRY(no_device, 0),    TRAP_TABLE_ENTRY(coproc_seg_overrun, 0),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1257: FILE: plat/xen/x86/traps.c:55:
+    TRAP_TABLE_ENTRY(invalid_tss, 0),  TRAP_TABLE_ENTRY(no_segment, 0),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1258: FILE: plat/xen/x86/traps.c:56:
+    TRAP_TABLE_ENTRY(stack_error, 0),  TRAP_TABLE_ENTRY(gp_fault, 0),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1259: FILE: plat/xen/x86/traps.c:57:
+    TRAP_TABLE_ENTRY(page_fault, 0),   TRAP_TABLE_ENTRY(spurious_int, 0),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1260: FILE: plat/xen/x86/traps.c:58:
+    TRAP_TABLE_ENTRY(coproc_error, 0), TRAP_TABLE_ENTRY(alignment_check, 0),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1261: FILE: plat/xen/x86/traps.c:59:
+    TRAP_TABLE_ENTRY(simd_error, 0),   {0, 0, 0, 0}};$

ERROR:SPACING: space required after that close brace '}'
#1261: FILE: plat/xen/x86/traps.c:59:
+    TRAP_TABLE_ENTRY(simd_error, 0),   {0, 0, 0, 0}};

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 20 warnings, 1262 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/build/a53d4c5b/patches/0001-removing-ifndef-CONFIG_PARAVIRT-code-27.patch has style problems, please review.

NOTE: Ignored message types: ASSIGN_IN_IF FILE_PATH_CHANGES NEW_TYPEDEFS OBSOLETE

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

---

View complete logs | Learn more about Unikraft's coding style and contribution guidelines.

[razvand]

@maruthgoyal , could you please take a look in this PR? Would you want it to be owned by someone else?

[razvand]

@StefanJum , please see if this PR is still useful / interesting to us. If so, please own it. If not, we'll close it.