-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library for generic unikernel control and monitoring (e.g., REST API) #5
Labels
kind/project
Issue is a substantial contribution
lifecycle/active
Indicates that an issue or PR is actively being worked on by a contributor.
Comments
felipehuici
added
the
lifecycle/active
Indicates that an issue or PR is actively being worked on by a contributor.
label
Oct 15, 2019
Closing this issues, since it's a duplicate of #539 |
eduardvintila
pushed a commit
to eduardvintila/unikraft_riscv64
that referenced
this issue
Jul 28, 2023
We need to set the LIBSYSCALL_SHIM_NOWRAPPER field in the configuration file to prevent syscall shim layer from creating system call wrappers. These wrappers are already defined in musl. Signed-off-by: Dragos Iulian Argint <dragosargint21@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Reviewed-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#5
eduardvintila
pushed a commit
to eduardvintila/unikraft_riscv64
that referenced
this issue
Jul 28, 2023
In the previous version, wrappers over system calls (e.g. `read ()`) were defined in syscall shim layer. Since we want to maintain musl as vanilla as possible, we have re-introduced these wrappers. Signed-off-by: Dragos Iulian Argint <dragosargint21@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Reviewed-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#5
eduardvintila
pushed a commit
to eduardvintila/unikraft_riscv64
that referenced
this issue
Jul 28, 2023
Musl wrappers use a binary system call, e.g. for x86_64 the `syscall` instruction is used which is a trap. In a single-address-space OS as an Unikraft unikernel this is just overhead. Hence, we changed the way musl deals with syscall handling by using some syscall shim layer macros. Those will replace binary system calls with function calls. Signed-off-by: Dragos Iulian Argint <dragosargint21@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Reviewed-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#5
eduardvintila
pushed a commit
to eduardvintila/unikraft_riscv64
that referenced
this issue
Jul 28, 2023
This patch was introduced to modify the prototype of the `ioctl()` function when it was exported directly from vfscore. Now, since we want to keep the wrapper in musl, we leave the function prototype unchanged. The patch is no longer needed. Signed-off-by: Dragos Iulian Argint <dragosargint21@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Reviewed-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#5
Neha151200
pushed a commit
to Neha151200/unikraft
that referenced
this issue
Mar 26, 2024
Add extra information for running the application on XEN environment Signed-off-by: Gabriel Mocanu <gabi.mocanu98@gmail.com> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: unikraft#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/project
Issue is a substantial contribution
lifecycle/active
Indicates that an issue or PR is actively being worked on by a contributor.
No description provided.
The text was updated successfully, but these errors were encountered: