-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-compat: Not a directory
error and assertion failure when running gzip
with app-elfloader
#858
Labels
kind/bug
Something isn't working
Comments
I can reproduce the assert. Looking into it... |
marcrittinghaus
added a commit
to marcrittinghaus/unikraft
that referenced
this issue
Apr 24, 2023
Previously, if pathname is either NULL or a relative path, and dirfd is not AT_FDCWD, dirfd needed to refer to a directory. However, in Linux there is a non-conformant behavior that if pathname is NULL, the timestamps are applied to whatever file dirfd refers to. For improved Linux compatibility, we adopt this behavior. This commit also fixes various leaks of the file descriptor reference that is received via the call to vfscore_get_file(). Github-Fixes: unikraft#858 Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io>
4 tasks
StefanJum
pushed a commit
to unikraft-upb/unikraft
that referenced
this issue
Jun 5, 2023
Previously, if pathname is either NULL or a relative path, and dirfd is not AT_FDCWD, dirfd needed to refer to a directory. However, in Linux there is a non-conformant behavior that if pathname is NULL, the timestamps are applied to whatever file dirfd refers to. For improved Linux compatibility, we adopt this behavior. This commit also fixes various leaks of the file descriptor reference that is received via the call to vfscore_get_file(). Github-Fixes: unikraft#858 Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Rares Miculescu <miculescur@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#865
razvanvirtan
pushed a commit
to razvanvirtan/unikraft
that referenced
this issue
Jun 6, 2023
Previously, if pathname is either NULL or a relative path, and dirfd is not AT_FDCWD, dirfd needed to refer to a directory. However, in Linux there is a non-conformant behavior that if pathname is NULL, the timestamps are applied to whatever file dirfd refers to. For improved Linux compatibility, we adopt this behavior. This commit also fixes various leaks of the file descriptor reference that is received via the call to vfscore_get_file(). Github-Fixes: unikraft#858 Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Rares Miculescu <miculescur@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using
app-elfloader
(via therun_app.sh
script inrun-app-elfloader
) to run thegzip
dynamic build and thegzip
static PIE build, aNot a directory
error appears based on autimensat
system call.Also, a dentry-related assertion appears. This is also part of the
echo
dynamic build and thels
dynamic build.Steps to reproduce
You can easily just use the
./do.sh
script in theunikraft-upb/scripts
repository:Expected behavior
There shouldn't be any errors printed.
Which architectures were you using or does this bug affect?
x86_64
Which platforms were you using or does this bug affect?
kvm
Relevant log output
The text was updated successfully, but these errors were encountered: