lib/nolibc: Fix & improve headers

[andreittr]

Description of changes

This PR addresses a couple of shortcomings in the headers provided with nolibc:

• Fix typo of CHAR_BIT being spelled as CHAR_BITS
• Add missing integer literal macros to stdint.h
• Add missing floating point constant headers (float.h + dependencies)

Prerequisite checklist

• Read the contribution guidelines regarding submitting new changes to the project;
• Tested your changes against relevant architectures and platforms;
• Ran the checkpatch.uk on your commit series before opening this PR;
• Updated relevant documentation.

Base target

• Architecture(s): N/A
• Platform(s): N/A
• Application(s): N/A

[DeliaPavel]

Looks good to me! It seems like the checkpatch failed, but I am ready to approve once it passes.

[andreittr]

Looks good to me! It seems like the checkpatch failed, but I am ready to approve once it passes.

I believe it's a case of a false positive from a heuristic script: the values of the macros aren't "complex", rather very plain float literals in scientific notation. The '+' must be confusing the script's regexes, but it won't confuse the compiler's lexer.
Regardless, in cases where we import files as-is from upstream projects as opposed to writing new code (like here from musl) I think avoiding unnecessary changes is worthwhile.

[DeliaPavel]

Reviewed-by: Delia Pavel delia_maria.pavel@stud.acs.upb.ro

[StefanJum]

This looks fine @andreittr, please rebase it on top of staging so the ci/cd tests can run.

[unikraft-bot]

❗ Checkpatch failed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request but it encountered errors:

SHA	commit	checkpatch
c1ca385	lib/nolibc: Fix typo in CHAR_BIT in limits.h	✅
3e59d9d	lib/nolibc: Add integer literal macros to stdint.h	✅
c8da4c5	lib/nolibc: Add missing floating point headers	❌

Truncated logs starting from first error c8da4c5:

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#42: FILE: lib/nolibc/musl-imported/arch/aarch64/bits/float.h:5:
+#define LDBL_MAX 1.18973149535723176508575932662800702e+4932L

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#68: FILE: lib/nolibc/musl-imported/arch/x86_64/bits/float.h:9:
+#define LDBL_MAX     1.1897314953572317650e+4932L

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#100: FILE: lib/nolibc/musl-imported/include/float.h:15:
+#define FLT_MAX 3.40282346638528859812e+38F

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#115: FILE: lib/nolibc/musl-imported/include/float.h:30:
+#define DBL_MAX 1.79769313486231570815e+308

total: 4 errors, 0 warnings, 95 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/build/a53d4c5b/patches/0003-lib-nolibc-Add-missing-floating-point-headers.patch has style problems, please review.

NOTE: Ignored message types: ASSIGN_IN_IF FILE_PATH_CHANGES NEW_TYPEDEFS OBSOLETE

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

---

View complete logs | Learn more about Unikraft's coding style and contribution guidelines.

[razvand]

@StefanJum, see this. The checkpatch items can be ignored, they're basically issues with the way checkpatch works. After you approve it, I'll cast the final approve.

[StefanJum]

All good, thanks.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

[razvand]

Approved-by: Razvan Deaconescu razvand@unikraft.io